Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F108 title, tweak G219 #3133

Merged
merged 7 commits into from
May 9, 2023
Merged

Fix F108 title, tweak G219 #3133

merged 7 commits into from
May 9, 2023

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Mar 31, 2023 •
edited

  • for G219, the title and wording are incorrect. they seem to suggest that "dragging movements" are not "single pointer" gestures, which they are (if they only involve a single pointer). what counts is that the alternative must be non-dragging-based and single pointer. Closes G219 for 2.5.7 Dragging Movement is misleading #3128
  • for F108, the title is incomplete (from when the SC number, and final title of the SC, weren't finalised yet)

@patrickhlauke
Change G219 to remove suggestion that "single pointer" is in contrast…
0e334a1 
… to dragging

Dragging movements can be single pointer gestures as well, it's not an either/or
@patrickhlauke
Fix title of F108
85c1091
@mbgower
Copy link
Contributor

mbgower commented Apr 3, 2023 •
edited

@patrickhlauke thanks for tackling.
I'm not entirely convinced that the title needs to be altered by making it longer, but I do think the wording changes in the techniques documents are good.
To me, if the title was simply "Ensuring that an alternative is available for dragging movements that operate on content" no one would likely be quibbling about it, since obviously the need is an alternative to dragging. Saying non-dragging here seems pretty redundant, at least in the title.
So, one way to shorten this title and make it clearer could be to actually just remove 'single-pointer'. All the changes in the document could still stand -- because of course it needs to be a single-pointer action.
I think it's okay for the failure to be more explicit, and that wording is already in place in any event, but I think for the sake of brevity, I'd be inclined to reduce length, not increase. Just a suggestion, and I'm fine with proposed language if anyone thinks it necessary.

mbgower
mbgower reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@mbgower mbgower left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the conversation, all changes make sense. I've made a suggestion for shortening the general technique title.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Apr 3, 2023 via email •
edited

patrickhlauke and others added 2 commits April 3, 2023 21:48
@patrickhlauke @mbgower
Update techniques/general/G219.html
0787219 
Co-authored-by: Mike Gower <mikegower@gmail.com>
@patrickhlauke @mbgower
Update techniques/general/G219.html
934d966 
Co-authored-by: Mike Gower <mikegower@gmail.com>
@patrickhlauke
Copy link
Member Author

currently on the road, let me check this when i'm back thursday night before doing anything with it...

@patrickhlauke
Copy link
Member Author

updated the link to the technique with the shorter title

@detlevhfischer
Copy link
Contributor

Looks like a no-brainer. Ready for survey?

alastc
alastc reviewed May 9, 2023
View reviewed changes
techniques/general/G219.html Outdated Show resolved Hide resolved
@alastc alastc merged commit 05ef083 into main May 9, 2023
1 check passed
@patrickhlauke patrickhlauke deleted the patrickhlauke-issue3128 branch May 9, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alastc alastc alastc left review comments

@mbgower mbgower mbgower left review comments

@detlevhfischer detlevhfischer detlevhfischer approved these changes

Assignees
No one assigned
Labels
2.5.7 Dragging Movements Techniques Understanding WCAG 2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

G219 for 2.5.7 Dragging Movement is misleading
4 participants
@patrickhlauke @mbgower @detlevhfischer @alastc